Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Do not rely on string representation in test #17905

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

vepadulano
Copy link
Member

@vepadulano vepadulano commented Mar 6, 2025

The string representation of the dataframe might change and it is not the purpose of this test anyway.

Part 2 of N for #17895

Copy link

github-actions bot commented Mar 6, 2025

Test Results

    18 files      18 suites   4d 4h 5m 33s ⏱️
 2 725 tests  2 724 ✅ 0 💤 1 ❌
47 351 runs  47 350 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit cf009c8.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (albeit it is a functional change :) ).

@vepadulano vepadulano merged commit c3d1c39 into root-project:master Mar 7, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants